Skip to content

Remove default temperature for ChatDatabricks #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 24, 2025
Merged

Conversation

bbqiu
Copy link
Collaborator

@bbqiu bbqiu commented Mar 21, 2025

  • no deprecation warning when temperature is passed in (either None or 0)
    • allow None to be compatible w/ EMs like o1
  • deprecation warning when temperature is not passed

tested here w/ o1 + llama: https://e2-dogfood.staging.cloud.databricks.com/editor/notebooks/1016946506451086?o=6051921418418893#command/7321788187864732

screenshot 2025-03-24-13-59-52-Arc

screenshot 2025-03-24-13-56-54-Arc

Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
@bbqiu bbqiu changed the title Remove default temperature for ChatDatabricks Remove default temperature for ChatDatabricks and fix scipy dependency issue for openai Mar 21, 2025
@bbqiu bbqiu changed the title Remove default temperature for ChatDatabricks and fix scipy dependency issue for openai Remove default temperature for ChatDatabricks and fix scipy dependency issue for openai/databricks-connect Mar 21, 2025
.
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
@bbqiu bbqiu force-pushed the bbqiu/chatdatabricks-temp branch from cad5ce6 to c269bf0 Compare March 21, 2025 20:22
@bbqiu bbqiu changed the title Remove default temperature for ChatDatabricks and fix scipy dependency issue for openai/databricks-connect Remove default temperature for ChatDatabricks Mar 21, 2025
bbqiu added 4 commits March 21, 2025 15:25
.
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
.
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
.
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
.
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
Signed-off-by: Bryan Qiu <bryan.qiu@databricks.com>
@bbqiu bbqiu enabled auto-merge (squash) March 24, 2025 21:01
@bbqiu bbqiu merged commit d721e5f into main Mar 24, 2025
5 checks passed
@bbqiu bbqiu deleted the bbqiu/chatdatabricks-temp branch March 24, 2025 21:02
@bbqiu
Copy link
Collaborator Author

bbqiu commented Mar 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants